Jump to content
r0bertz

Porting ripple-client-desktop to RippleAPI

Recommended Posts

https://github.com/r0bertz/ripple-client-desktop/commits/master

I have been working on this since last month. Most of the functions are working, including trading.

Just follow README to build https://github.com/r0bertz/ripple-client-desktop

There is no executable files yet. I haven't built any packages.

I plan to create a huge PR after this is all done. In the meantime, feel free to fork and play with it.

Also you can follow this twitter thread for the most recent updates:

 

Share this post


Link to post
Share on other sites
1 hour ago, Vokez said:

Hello @r0bertz 

We have a fork of the Ripple Client Desktop that compiles in node v4.9.1.

We have not had experienced any incompatibility issues against #rippled v1.1.2

You can find our repo here: https://github.com/VokezOfficial/systemd-desktop-wallet

the ripple client desktop use old ripple-lib which was deprecated. @r0bertz's effort is porting the code to use new ripple-lib "rippleApi".

the old ripple-lib didn't support new features of the XRPL, like escrow, muitisign, checks etc.

Edited by yxxyun

Share this post


Link to post
Share on other sites

If you plan to use this version forever, then you can ignore my work.

"ripple-lib": "0.13.0-rc14"

One big change I made was I removed offline signing feature. Because https://developers.ripple.com/reliable-transaction-submission.html Basically to reliably submit a transaction, the transaction must specify a ledger number at which if the transaction is still not included, then consider it fail. To obtain that ledger number, we must know the last closed ledger at the time of signing. This can't be done in offline mode. 

One workaround would be to allow setting LastLedgerSequence in the UI in offline signing (then you would have to get LastLedgerSequence in a different app). Feel free to bring it back if you really need it.

Edited by r0bertz

Share this post


Link to post
Share on other sites
5 hours ago, r0bertz said:

If you plan to use this version forever, then you can ignore my work.


"ripple-lib": "0.13.0-rc14"

One big change I made was I removed offline signing feature. Because https://developers.ripple.com/reliable-transaction-submission.html Basically to reliably submit a transaction, the transaction must specify a ledger number at which if the transaction is still not included, then consider it fail. To obtain that ledger number, we must know the last closed ledger at the time of signing. This can't be done in offline mode.  

One workaround would be to allow setting LastLedgerSequence in the UI in offline signing (then you would have to get LastLedgerSequence in a different app). Feel free to bring it back if you really need it. 

You should absolutely allow offline signing with an explicitly-specified LastLedgerSequence.

The best practices for good security are to have an online machine (that you can check the LastLedgerSequence, etc. on) and an offline machine (to do the actual signing), then use a method such as QR codes or disposable factory-fresh USB drives to transfer signed transactions from an offline machine to the online machine for submission.

Share this post


Link to post
Share on other sites

×
×
  • Create New...