Jump to content

rammican

Member
  • Content Count

    10
  • Joined

  • Last visited

About rammican

  • Rank
    Regular

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. I was just looking through this topic by tulo: https://www.xrpchat.com/topic/8223-rippleapi-orderbooks-order-is-by-string-quality/?tab=comments#comment-78458 and decided to reproduce the problem he was having. When I started playing around with limit option I noticed something odd. Looking up the XRP / CNY rKiCet8SdvWxPXnAgYarFUXMh1zCPz432Y book with the option.limit set to 1 would not always return a result for both the bid and ask. When I up the limit to 5 or 10 it always returned for both. Any ideas on why this might be happening? I can think of a lot of use cases for wanting a limit of 1 since it should return the top bid and ask quality. This coupled with the string sorting brought up in tulo's post means that you need to return the entire orderbook, re-sort, then take the top quality to ensure that you are getting it. Seems like a lot of work.
  2. I'm really new to all of this so I hope my logic makes sense here. I do agree that it would be nice to have more nuanced messages such as tecNONEXISTING but I also see fillOrKill as having a higher need than others for two reasons: 1) fillOrKill has a certain time sensitive connotation that stems from its use in securities trading. New people to ripple will probably get confused by tesSUCCESS. 2)If OfferCancel returns tesSUCCESS you know that your offer is either canceled or nonexistent which should lead to the same desired outcome. So with OfferCancel tesSUCCESS means that you know the potential outcome: no longer having an open order if validated. fillOrKill is different in that when tesSUCCESS is returned you know nothing about the potential outcome and you have to wait for validation to see what happened.
  3. Thanks!! @tulo I'm really new to all of this so I just want to make sure that I'm understanding your metadata suggestion. Basically, I need to check the balanceChanges when using getTransaction to verify? I do think tecKILLED will add a lot of value because from my limited experience so far, it can sometimes take 4 or more seconds to verify the transaction after getting a tesSUCCESS. I'd much rather just get tecKILLED and forgo process of getTransaction. It's also just less confusing for newbies ;).
  4. Returning tecKILLED would be really helpful. This probably warrants a different topic on this forum but what is current best practice for determining orders that are filled vs. killed. Or we can be even more general, what is the best practice for determining if any order is filled. E.g. For the Ripple API- get balance for currency -> place order -> if tesSUCCESS -> monitor if balance changes? But this seems less effective then just subscribing to an orderbook through a websocket request on rippled. Then you can monitor your orders. I'd love to hear others thoughts.
  5. I may be misinterpreting how the fillOrKill flag works but I have had multiple orders now that are coming through as successful but that are not filling? I am getting tesSUCCESS as the final result yet my balances do not change. How is this possible? Doesn't fillOrKill ensure that the balances change or the order is cancelled?
  6. Thanks! That makes sense and I will look into the freeze flag more which is exactly what I was looking for. I also found this https://data.ripple.com/v2/gateways as part of the Data API v2 Tool. It would be great to hear more about the process that Ripple uses to determine an asset being set to featured: true. I did find one frozen asset that was set to true but for the most part all of the trues seemed to have good volume.
  7. I just tried running it again and it worked twice??? No errors these times. So I had 9 failed transactions with the error and two that worked. I am connecting to the public server from the Beginners Guide. Could that have something to do with this? E.g. just a ton of api calls to it?
  8. Shouldn't the path convert it into the trusted currency? The way that I understand this based on the documentation is that I am sending GateHub USD the path converts it in the following orderbooks: myAddrOne -----> USD-GateHUB / BTC-BitStamp ---> BTC-BitStamp/USD-BitStamp----> myAddrTwo
  9. I'm trying to understand how to send a payment with paths but I keep getting a tecPATH_DRY error. I've looked up the error @ https://ripple.com/build/transactions/ and I am certain that my path has the required liquidity and that the trustlines are correctly set. Here is my object. If you look at my path, I chose orderbooks that have plenty of volume and I am only requesting to receive .001 for sending .02 (e.g. this would be a terrible path to take but there should be plenty of liquidity). My destination address has trustlines set for BitStamp USD. Any ideas? var myPayment = { "source": { "address": myAddrOne, "amount": { "value": '.02', "currency": 'USD', "counterparty": 'rhub8VRN55s94qWKDv6jmDy1pUykJzF3wq' } }, "destination": { "address": myAddrTwo, "minAmount": { "value": '0.001', "currency": 'USD', "counterparty": 'rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B' } }, "allowPartialPayment": true, "noDirectRipple": true, "paths": '[[{"currency":"BTC","issuer":"rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B"},{"currency":"USD","issuer":"rvYAfWj5gh67oV6fW32ZzP3Aw4Eubs59B"}]]' };
  10. So I am just getting into the Ripple API and I was looking at a lot of Orderbooks of different currency pairs and comparing them to Ripple Charts so that I could understand the returned object. Anyways I noticed that the API was returning some order books that were not showing up on Ripple Charts. Being curious I tried to trade a very small amount on the currency and got an Error Message that the asset was frozen. So my questions are: Where can I look up the gateways that have tradable assets on Ripple? There are so many on Ripple Charts that I don't have the counterparty address for. How can I make sure that the currency isn't frozen besides trading it? Basically, I'd rather not even look up an Orderbook for that asset. I think it is really weird that getOrderBook returns an object for a asset that is frozen.
×
×
  • Create New...